Fix ghp-to-storage dispatch #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zolanaj
commented
May 9, 2024
zolanaj
commented
- Prevents a bug in which the model fails to build when both GHP and thermal storage are present
- While decision variables are present for GHP to charge to storage, these are fixed to zero, i.e., GHP cannot charge storage (which is consistent with the original formulation for GHP; it only served load previously)
adfarth
reviewed
May 9, 2024
adfarth
reviewed
May 9, 2024
adfarth
reviewed
May 9, 2024
|
Adding a note here to double check that |
I caught a couple others in addition to the ones you showed, and fixed them here: 4283794 |
adfarth
approved these changes
May 9, 2024
Merged
indu-manogaran
pushed a commit
that referenced
this pull request
Sep 16, 2024
Fix ghp-to-storage dispatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.